feat: handle remaining translations #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flagrede
force-pushed
the
feat-translate-remaining
branch
from
2f670c0
to
36faa55
Compare
blushi
approved these changes
Sep 24, 2024
| @@ -4,19 +4,37 @@ import { OrderSummaryImage } from './OrderSummaryCard.Image'; | |||
| import { OrderSummaryProps } from './OrderSummaryCard.types'; | |||
There was a problem hiding this comment.
I'm actually moving this component to web-marketplace in another PR that hasn't been merged yet, but if that's too much work to revert the changes here, all good, I'll deal with the conflicts
There was a problem hiding this comment.
Ok, well, reverting this file would also revert some others. I think applying these changes to the moved file might be easier. Let me know if you need any help with that.
| @@ -12,4 +14,6 @@ export const bottomTextMapping = { | |||
| countryLabel: 'Country', | |||
| stateLabel: 'State / Region', | |||
| postalCodeLabel: 'Postal Code', | |||
| locationStatePlaceholderLabel: 'State / Region', | |||
There was a problem hiding this comment.
what's the difference between this and stateLabel?
There was a problem hiding this comment.
The mock is incorrect; it should be Please choose a state, I'll update it thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle remaining translations.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...